Remove compilers dependency from conda environment and force install x64 git in OSX Github Action workflows#2420
Merged
valeriupredoi merged 6 commits intomainfrom May 15, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2420 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 246 246
Lines 14023 14023
=======================================
Hits 13254 13254
Misses 769 769 ☔ View full report in Codecov by Sentry. |
valeriupredoi
changed the title
bouweandela
reviewed
May 15, 2024
Member
bouweandela
left a comment
bouweandela
left a comment
There was a problem hiding this comment.
Looks fine to me @valeriupredoi, could you clean up a bit?
The compilers package was needed a long time ago, when we were still installing most packages from PyPI and only those that weren't on PyPI from conda.
bouweandela
approved these changes
May 15, 2024
Contributor
Author
|
Thanky, bud 🍺 |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #2419
compilerswas added by @bouweandela four years ago in #603 - see #603 (comment) - I don't think we still need it but may be worth checking the docker build goes well without it anywayOSX tests: failing with "setuptools_scm._run_cmd.CommandNotFoundError: git" - this has been seen in ESMValGroup/ESMValTool#3581 and it's not hitting just this node, but rather, it's an endemic issue related to macOS 14 on arm64:
For some reason, the system git goes fishing when the x64 environment is activated and used - @schlunma and I had a decent debate about it in the linked Tool PR - no time to really-really understand the issue, just plop a git installer in the workflow!
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: